[PATCH:xf86-video-mga] Fix pointer cast warning.

Connor Behan connor.behan at gmail.com
Wed Feb 25 23:59:49 PST 2015

On 25/02/15 06:41 PM, Tormod Volden wrote:
>> And then disable the DownloadFromScreen() implementation, or perhaps
>> even disable EXA altogether.
> If nobody can find the real problem that is maybe all that can be done.
The fix should be:

char *src = pExa->memoryBase + exaGetPixmapOffset(pSrc);

When I first saw exaGetPixmapFirstPixel() in savage and mga, I assumed
this was just a shorthand for the above. But evidently it's not. As for
other broken EXA drivers, I don't have hardware to test but some basic
suggestions are:

1. Use the above instead of pPix->devPrivate.ptr.
2. Make all hooks start by verifying that pSrc is non-NULL.
3. Remove UTS / DFS hooks unless they actually do a DRM blit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150226/a0580ecb/attachment.sig>

More information about the xorg-devel mailing list