[PATCH] os: make sure the clientsWritable fd_set is initialized before use

Dave Airlie airlied at gmail.com
Sun Aug 23 21:24:45 PDT 2015


On 24 August 2015 at 04:05, Keith Packard <keithp at keithp.com> wrote:
> Martin Peres <martin.peres at free.fr> writes:
>
>> We have been discussing in private with Keith. It seems like the both of
>> us do not have the time to properly fix the issue. I would say let's
>> push this fix and get rid of all this complexity later! I really do not
>> see when I will have the time for it and this patch is doing the right
>> thing, even if it is not addressing the complexity issue which means it
>> will blow in our faces again later on unless someone takes the time to
>> properly fix it!
>
> It seems like a simpler fix would be to revert the change to x11proto that
> caused this problem in the first place; given that the X server will not
> ever use more than MAXCLIENTS fds for devices and clients, there doesn't
> seem to be any value in having x11proto allocate larger arrays of fd
> masks for select.
>

except for the patch series that has been posted multiple times that this xproto
change is a pre requirement for, how about we just fix the X server already.

and maybe pull in the patch series.
Dave.


More information about the xorg-devel mailing list