[PATCH] os: make sure the clientsWritable fd_set is initialized before use

Keith Packard keithp at keithp.com
Sun Aug 23 11:05:56 PDT 2015


Martin Peres <martin.peres at free.fr> writes:

> We have been discussing in private with Keith. It seems like the both of 
> us do not have the time to properly fix the issue. I would say let's 
> push this fix and get rid of all this complexity later! I really do not 
> see when I will have the time for it and this patch is doing the right 
> thing, even if it is not addressing the complexity issue which means it 
> will blow in our faces again later on unless someone takes the time to 
> properly fix it!

It seems like a simpler fix would be to revert the change to x11proto that
caused this problem in the first place; given that the X server will not
ever use more than MAXCLIENTS fds for devices and clients, there doesn't
seem to be any value in having x11proto allocate larger arrays of fd
masks for select.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150823/8311b44d/attachment.sig>


More information about the xorg-devel mailing list