[PATCH] backtrace.c: Fix word cast to a pointer

Matt Turner mattst88 at gmail.com
Wed Apr 1 14:42:40 PDT 2015

On Wed, Apr 1, 2015 at 2:13 AM, Vicente Olivert Riera
<Vincent.Riera at imgtec.com> wrote:
> Hello,
> On 01/08/2015 10:36 PM, Keith Packard wrote:
>> Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
>>> Making the cast to a pointer-sized integer, and then to a pointer fixes
>>> the problem.
>>> -        if (dladdr((void *)(pip.start_ip + off), &dlinfo) && dlinfo.dli_fname &&
>>> +        if (dladdr((void *)(long)(pip.start_ip + off), &dlinfo) && dlinfo.dli_fname &&
>> I'd suggest using uintptr_t instead of long if you want a pointer-sized
>> integer.
> out of curiosity. Why is taking so long for this patch to be applied
> upstream?

I don't see that you ever sent an updated patch. Though I do have a
vague memory of making the same comment as Keith, I can't find the
thread I would have made it in.

More information about the xorg-devel mailing list