[PATCH] backtrace.c: Fix word cast to a pointer

Vicente Olivert Riera Vincent.Riera at imgtec.com
Wed Apr 1 02:13:18 PDT 2015


Hello,

On 01/08/2015 10:36 PM, Keith Packard wrote:
> Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
> 
>> Making the cast to a pointer-sized integer, and then to a pointer fixes
>> the problem.
> 
>> -        if (dladdr((void *)(pip.start_ip + off), &dlinfo) && dlinfo.dli_fname &&
>> +        if (dladdr((void *)(long)(pip.start_ip + off), &dlinfo) && dlinfo.dli_fname &&
> 
> I'd suggest using uintptr_t instead of long if you want a pointer-sized
> integer.
> 

out of curiosity. Why is taking so long for this patch to be applied
upstream?

Regards,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com


More information about the xorg-devel mailing list