[PATCH 18/19] xfree86: Remove driver entity hooks and private

[Adam Jackson]

On Mon, 2014-09-29 at 13:49 -0700, Keith Packard wrote:
> Mark Kettenis <mark.kettenis at xs4all.nl> writes:
> 
> >> From: Adam Jackson <ajax at redhat.com>
> >> Date: Thu, 25 Sep 2014 13:37:34 -0400
> >> 
> >> No driver is using these, as far as I know.
> >
> > The xf86-video-mga driver uses these, but only if DISABLE_VGA_IO is
> > defined, and by default it isn't, and there is no configure option to
> > turn it on.
> >
> > I'm a bit worried about silently ignoring the arguments passed to
> > xf86ConfigFbEntity* and xf86ConfigPciEntity*.  Perhaps throw a fatal
> > error if any of the function pointers is non-NULL?
> 
> I'd rather just change the API to eliminate these pointers; every single
> driver will then have to review the change and make sure it's correct.

"Every single driver" here actually meaning "the guy pushing the
change", but sure, I can do that.

Can we consider coming up with a heuristic for the oldest server version
that current git versions of drivers will continue to support?  The
amount of #ifdef in the drivers is getting a bit absurd, and it's a bit
disingenuous to pretend our support goes back as far as we currently let
build.

- ajax