[PATCH 18/19] xfree86: Remove driver entity hooks and private

Keith Packard keithp at keithp.com
Mon Sep 29 13:49:22 PDT 2014


Mark Kettenis <mark.kettenis at xs4all.nl> writes:

>> From: Adam Jackson <ajax at redhat.com>
>> Date: Thu, 25 Sep 2014 13:37:34 -0400
>> 
>> No driver is using these, as far as I know.
>
> The xf86-video-mga driver uses these, but only if DISABLE_VGA_IO is
> defined, and by default it isn't, and there is no configure option to
> turn it on.
>
> I'm a bit worried about silently ignoring the arguments passed to
> xf86ConfigFbEntity* and xf86ConfigPciEntity*.  Perhaps throw a fatal
> error if any of the function pointers is non-NULL?

I'd rather just change the API to eliminate these pointers; every single
driver will then have to review the change and make sure it's correct.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140929/5e6c1b50/attachment-0001.sig>


More information about the xorg-devel mailing list