[PATCH 01/19] damageext: dixLookupDrawable(M_WINDOW) -> dixLookupWindow

Keith Packard keithp at keithp.com
Mon Sep 29 13:25:43 PDT 2014


Adam Jackson <ajax at redhat.com> writes:

> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  damageext/damageext.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/damageext/damageext.c b/damageext/damageext.c
> index 886f56d..4928379 100644
> --- a/damageext/damageext.c
> +++ b/damageext/damageext.c
> @@ -687,9 +687,8 @@ PanoramiXDamageCreate(ClientPtr client)
>                  rc = BadAlloc;
>              } else {
>                  damage->damage[i] = pDamage;
> -                rc = dixLookupDrawable(&pDrawable, draw->info[i].id, client,
> -                                       M_WINDOW,
> -                                       DixGetAttrAccess | DixReadAccess);
> +                rc = dixLookupWindow((WindowPtr *)&pDrawable, draw->info[i].id,
> +                                     client, DixGetAttrAccess | DixReadAccess);

This does change the error code from BadMatch to BadWindow, if the
object isn't found. Given that this is a Drawable on the wire, we should
leave this alone, even though an error here would indicate a bug in the
xinerama code.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140929/6868d4fd/attachment-0001.sig>


More information about the xorg-devel mailing list