[PATCH 1.5/4 util-modular] release.sh: force /bin/bash

Matthieu Herrb matthieu at herrb.eu
Sun Jun 1 23:22:15 PDT 2014


On Sun, Jun 01, 2014 at 08:52:34PM -0700, Alan Coopersmith wrote:
> On 06/ 1/14 08:18 PM, Peter Hutterer wrote:
> >Trying to meet a hard-to-test standard of /bin/sh is unnecessary for a script
> >that's only run by maintainers. For now, simply force bash but don't change
> >any of the script, over time we can update this to support true bashism like
> >[[ ]].
> >
> >Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> >---
> >  release.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/release.sh b/release.sh
> >index e5774c2..a8d3451 100755
> >--- a/release.sh
> >+++ b/release.sh
> >@@ -1,4 +1,4 @@
> >-#!/bin/sh
> >+#!/bin/bash
> >  #
> >  #		Creates and upload a git module tarball
> >  #
> >
> 
> Fine by me for Solaris - every non-EOL version has bash available, just
> not installed as /bin/sh.  I can't speak for the other platforms though.
> 
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 

As far as OpenBSD is concerned I don't care. OpenBSD doesn't have
/bin/bash but I could cope with that locally next time I need it.

-- 
Matthieu Herrb


More information about the xorg-devel mailing list