[PATCH 1.5/4 util-modular] release.sh: force /bin/bash
Alan Coopersmith
alan.coopersmith at oracle.com
Sun Jun 1 20:52:34 PDT 2014
On 06/ 1/14 08:18 PM, Peter Hutterer wrote:
> Trying to meet a hard-to-test standard of /bin/sh is unnecessary for a script
> that's only run by maintainers. For now, simply force bash but don't change
> any of the script, over time we can update this to support true bashism like
> [[ ]].
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> release.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/release.sh b/release.sh
> index e5774c2..a8d3451 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
> #
> # Creates and upload a git module tarball
> #
>
Fine by me for Solaris - every non-EOL version has bash available, just
not installed as /bin/sh. I can't speak for the other platforms though.
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
(For the morbidly curious, Solaris 10 and older have a pre-historic, pre-POSIX
version of the Bourne shell from SVR4.0 as /bin/sh - you can find a port to
other platforms at heirloom.sf.net. Solaris 11 & later have ksh93 as /bin/sh,
though we're watching to see how it survives the loss of the AT&T/Bell Labs
support going forward.)
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
More information about the xorg-devel
mailing list