[PATCH] glamor: sync_fence_set_triggered should use glFlush, not glFinish

Jasper St. Pierre jstpierre at mecheye.net
Sat Jul 19 04:15:32 PDT 2014


Reviewed-by: Jasper St. Pierre <jstpierre at mecheye.net>


On Sat, Jul 19, 2014 at 12:48 AM, Keith Packard <keithp at keithp.com> wrote:

> I intended to use glFlush all along, but somehow managed to type
> glFinish instead. glFlush is sufficient (for a single-queue GPU) to
> ensure serialization between queued rendering in the X server and
> future rendering from the client.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  glamor/glamor_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/glamor/glamor_sync.c b/glamor/glamor_sync.c
> index d3d64a9..5e158c3 100644
> --- a/glamor/glamor_sync.c
> +++ b/glamor/glamor_sync.c
> @@ -53,7 +53,7 @@ glamor_sync_fence_set_triggered (SyncFence *fence)
>
>         /* Flush pending rendering operations */
>          glamor_make_current(glamor);
> -        glFinish();
> +        glFlush();
>
>         fence->funcs.SetTriggered = glamor_fence->set_triggered;
>         fence->funcs.SetTriggered(fence);
> --
> 2.0.1
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140719/908f8bb6/attachment.html>


More information about the xorg-devel mailing list