[PATCH xserver] test: create a link to the generated hw/xfree86/sdksyms.c at build time

[Gaetan Nadon]

On 14-02-23 11:46 PM, Keith Packard wrote:
> Gaetan Nadon <memsize at videotron.ca> writes:
>
>> Automake 1.14 gives us warning about source code specified in _SOURCES
>> that comes from directories other than the current one. It suggests to enable
>> the subdir-objects feature which only supports code in sub
>> directories.
> Can we turn on the subdir-objects feature after this patch then?
>
Not yet. And it would be only for this Makefile.am, not for the whole
server code.

There are those three other cases to handle:

    nodist_libxservertest_la_SOURCES = \
                ddxstubs.c \
                $(top_srcdir)/mi/miinitext.c \
                $(top_srcdir)/Xext/dpmsstubs.c \
                $(top_srcdir)/Xi/stubs.c

Jon Turney just posted a patches "Build Xi and DPMS stubs as convenience
libraries" which takes care of two out of the three cases (If I
understand correctly, just done a quick read). That would leave
miinitext.c to handle.

Note that we do not "need" the subdir-objects feature, but automake 2.0
will turn it on any (and it cannot be turned off). We happen to have
code that will trip this feature. So we need to fix it before 2.0 gets
pervasive.

This is the complete list of Makefile.am affected by this issue.

 Xi/Makefile.am                            
 fb/Makefile.am                            
 hw/dmx/Makefile.am                        
 hw/dmx/config/Makefile.am                 
 hw/kdrive/src/Makefile.am                 
 hw/vfb/Makefile.am                        
 hw/xfree86/dixmods/Makefile.am            
 hw/xfree86/int10/Makefile.am              
 hw/xfree86/os-support/bsd/Makefile.am     
 hw/xfree86/os-support/hurd/Makefile.am    
 hw/xfree86/os-support/linux/Makefile.am   
 hw/xfree86/os-support/solaris/Makefile.am 
 hw/xfree86/os-support/stub/Makefile.am    
 hw/xfree86/parser/Makefile.am             
 hw/xfree86/utils/cvt/Makefile.am          
 hw/xnest/Makefile.am                      
 hw/xquartz/Makefile.am                    
 hw/xquartz/mach-startup/Makefile.am       
 hw/xwin/Makefile.am                       
 test/Makefile.am                          

The other area that has not been tackled yet is in the os-support and
the "shared" directory:

Mark Kettenis has commented:

    "Note that not all warnings are actually problems.  For example the
    directories under hw/xfree86/os-support are largely subdir-objects
    safe.  Probably enough to make sure hw/xfree86/os-support/shared gets
    created in the build directory before entering the OS-specific
    directory.  The same is probably true for os/strlcpy.c and
    os/strlcat.c.  Although those files are defenitely candidates for a
    libtool convenience library".




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140224/7f09067b/attachment-0001.html>