<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 14-02-23 11:46 PM, Keith Packard wrote: </div> <blockquote cite="mid:86sir9p16r.fsf@hiro.keithp.com" type="cite"> <pre wrap="">Gaetan Nadon <a class="moz-txt-link-rfc2396E" href="mailto:memsize@videotron.ca"><memsize@videotron.ca></a> writes: </pre> <blockquote type="cite"> <pre wrap="">Automake 1.14 gives us warning about source code specified in _SOURCES that comes from directories other than the current one. It suggests to enable the subdir-objects feature which only supports code in sub directories. </pre> </blockquote> <pre wrap=""> Can we turn on the subdir-objects feature after this patch then? </pre> </blockquote> Not yet. And it would be only for this Makefile.am, not for the whole server code. There are those three other cases to handle: <blockquote><tt>nodist_libxservertest_la_SOURCES = \</tt><tt> </tt><tt> ddxstubs.c \</tt><tt> </tt><tt> $(top_srcdir)/mi/miinitext.c \</tt><tt> </tt><tt> $(top_srcdir)/Xext/dpmsstubs.c \</tt><tt> </tt><tt> $(top_srcdir)/Xi/stubs.c</tt><tt> </tt></blockquote> Jon Turney just posted a patches "Build Xi and DPMS stubs as convenience libraries" which takes care of two out of the three cases (If I understand correctly, just done a quick read). That would leave miinitext.c to handle. Note that we do not "need" the subdir-objects feature, but automake 2.0 will turn it on any (and it cannot be turned off). We happen to have code that will trip this feature. So we need to fix it before 2.0 gets pervasive. This is the complete list of Makefile.am affected by this issue. <pre wrap=""> Xi/Makefile.am fb/Makefile.am hw/dmx/Makefile.am hw/dmx/config/Makefile.am hw/kdrive/src/Makefile.am hw/vfb/Makefile.am hw/xfree86/dixmods/Makefile.am hw/xfree86/int10/Makefile.am hw/xfree86/os-support/bsd/Makefile.am hw/xfree86/os-support/hurd/Makefile.am hw/xfree86/os-support/linux/Makefile.am hw/xfree86/os-support/solaris/Makefile.am hw/xfree86/os-support/stub/Makefile.am hw/xfree86/parser/Makefile.am hw/xfree86/utils/cvt/Makefile.am hw/xnest/Makefile.am hw/xquartz/Makefile.am hw/xquartz/mach-startup/Makefile.am hw/xwin/Makefile.am test/Makefile.am </pre> The other area that has not been tackled yet is in the os-support and the "shared" directory: Mark Kettenis has commented: <blockquote> <pre wrap="">"Note that not all warnings are actually problems. For example the directories under hw/xfree86/os-support are largely subdir-objects safe. Probably enough to make sure hw/xfree86/os-support/shared gets created in the build directory before entering the OS-specific directory. The same is probably true for os/strlcpy.c and os/strlcat.c. Although those files are defenitely candidates for a libtool convenience library".</pre> </blockquote> </body> </html>