glamor regressions with radeonsi (Re: xserver: Branch 'master' - 15 commits)

Michel Dänzer michel at daenzer.net
Mon Apr 7 02:33:04 PDT 2014


Test case:

     1. Start 'naked' Xorg with an xterm: xinit =xterm -- :1 -retro &
     2. Start xfwm4: DISPLAY=:1 xfwm4 &
     3. Maximize and unmaximize xterm window


There are at least two regressions introduced by the latest glamor
series:

> commit 3c34dd3603989c0365654ca1b6809395c7f3b169
> Author: Keith Packard <keithp at keithp.com>
> Date:   Tue Apr 1 21:15:48 2014 -0700
> 
>     glamor: Add glamor_program based poly_text and image_text
>     
>     Accelerates text painting with GPU-based geometry computation and stippling
>     
>     v2: Simplify get_glyphs, expand single character variable names to
>         more descriptive ones. (Markus Wick)
>     v3: Rebase against the glamor_prepare_* un-renaming (changes by anholt).
>     
>     Improves x11perf -f8text by 417.908% +/- 11.0144% (n=10)
>     
>     Signed-off-by: Keith Packard <keithp at keithp.com>
>     Signed-off-by: Eric Anholt <eric at anholt.net>
>     Reviewed-by: Eric Anholt <eric at anholt.net>

As of this commit, the text in the xterm window is not visible after
step 1. It only becomes visible after step 2.


> commit 3411e8c538476443cafbb70082ef7457932e4a38
> Author: Keith Packard <keithp at keithp.com>
> Date:   Tue Apr 1 21:15:46 2014 -0700
> 
>     glamor: Add glamor_program based poly_fill_rect
>     
>     This accelerates poly_fill_rect using GPU-based geometry computation
>     
>     Improves x11perf -rect100 by 41.5127% +/- 7.63888% (n=10)
>     Improves x11perf -rect10 by 3745.72% +/- 94.7503% (n=6)
>     
>     v2: Rebase on skipping the prepare rewrite for now, and fix the GLSL
>         1.20 and GLES2 cases (changes by anholt).
>     
>     Signed-off-by: Keith Packard <keithp at keithp.com>
>     Signed-off-by: Eric Anholt <eric at anholt.net>
>     Reviewed-by: Eric Anholt <eric at anholt.net>

As of this commit, step 3 produces garbage in the xterm window
decorations, in particular the title and bottom bars.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer



More information about the xorg-devel mailing list