[PATCH][vmware] build: add explicit option to enable/disable VMWGFX

[Jakob Bornecrantz]

On Fri, Sep 13, 2013 at 10:08 AM, Burton, Ross <ross.burton at intel.com>wrote:

> On 13 September 2013 06:01, Jakob Bornecrantz <wallbraker at gmail.com>
> wrote:
> > If I'm reading this correctly this will cause the build to fail if
> > you don't give it the disable flag if xatracker is missing?
> > I'm on the fence if we want this, is this a problem you have
> > run into?
>
> Correct, defaults to enabled and will fail if the dependencies are not
> present.  If required I could add an "auto" option alongside the
> explicit on and off options.
>
> As a best practise our metadistro (Yocto Project) avoids
> auto-detection because it leads to undeterministic builds: one day the
> build order changes and if you forgot an explicit dependency, the
> compilation changes.
>

Ah you are right that does make sense, thank you for explaining,
I will commit this patch later, and it is

Reviewed-by: Jakob Bornecrantz <jakob at vmware.com>

Cheers, Jakob.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130913/ce5c7dd6/attachment.html>