[PATCH:libpciaccess 1/3] Enable boot_vga support only if WSDISPLAYIO_GET_BUSID is defined.

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jun 12 13:51:57 PDT 2013


On 06/12/13 06:22 AM, walter harms wrote:
>
>
> Am 12.06.2013 13:43, schrieb Thomas Klausner:
>> Fixes build on NetBSD-5.
>> ---
>>   src/netbsd_pci.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/src/netbsd_pci.c b/src/netbsd_pci.c
>> index 3566d7b..c9bd052 100644
>> --- a/src/netbsd_pci.c
>> +++ b/src/netbsd_pci.c
>> @@ -248,6 +248,7 @@ pci_device_netbsd_write(struct pci_device *dev, const void *data,
>>   	return 0;
>>   }
>>
>> +#if defined(WSDISPLAYIO_GET_BUSID)
>>   static int
>>   pci_device_netbsd_boot_vga(struct pci_device *dev)
>>   {
>
>
> IMHO you can improve readability when you provide a dummy function for pci_device_netbsd_boot_vga()

Perhaps I'm weird, but I don't find a dummy function more readable, just see it
as increased maintenance work.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list