NetBSD-specific changes for xf86-input-keyboard

Thomas Klausner wiz at NetBSD.org
Sun Jul 28 07:28:01 PDT 2013


On Fri, Jul 26, 2013 at 06:40:33PM -0700, Alan Coopersmith wrote:
> For patches 1-7, 9-11,  while I can't verify you've chosen the right
> values for those keycodes, I assume you and your users have already tested
> that out, and since the way you've set them looks fine:
>   Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
> Patches 8, 12, 18, seem to require more platform specific knowledge
> than I have of your platform.   They don't seem wrong, I just don't know if
> they're right.  Since they're credited to other authors, would you consider
> yourself to have reviewed them and be willing to offer up the r-b for them?
> 
> Patches 13, 15, 21 I replied directly to with comments before giving r-b.
> 
> Patches 14, 16, 17, 19, 20 seem simple enough to review without platform
> knowledge, and look fine to me, so those can also have:
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Thank you for the reviews.

> Since this is a huge pile of patches, and you've been upstreaming a lot lately,
> is it time to discuss git commit access so you can push them yourself instead
> of having to wait both for someone to review and for a committer to push?

I'd appreciate that! Let me know how to go forward on this one, and
please also tell me how to use the commit bit properly.

Thanks,
 Thomas


More information about the xorg-devel mailing list