[PATCH 3/5] ephyr: Fix compilation when ./configure'd with --enable-debug

Jon TURNEY jon.turney at dronecode.org.uk
Sun Dec 8 09:11:37 PST 2013


On 05/12/2013 18:39, Keith Packard wrote:
> Jon TURNEY writes:
> 
>>      xcb_button_press_event_t *button = (xcb_button_press_event_t *)xev;
>> +    KdScreenInfo *screen = screen_from_window(button->event);
> 
> I suspect you won't want a local variable here -- when debug isn't
> enabled, this variable won't be used at all, right? So, just in-line the
> value each place it is used. (there are two instances of exactly this code)

Yes.  Changed as suggested in v2.



More information about the xorg-devel mailing list