[PATCH 3/5] ephyr: Fix compilation when ./configure'd with --enable-debug

Keith Packard keithp at keithp.com
Thu Dec 5 10:39:32 PST 2013


Jon TURNEY <jon.turney at dronecode.org.uk> writes:

>      xcb_button_press_event_t *button = (xcb_button_press_event_t *)xev;
> +    KdScreenInfo *screen = screen_from_window(button->event);

I suspect you won't want a local variable here -- when debug isn't
enabled, this variable won't be used at all, right? So, just in-line the
value each place it is used. (there are two instances of exactly this code)

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131205/e487f356/attachment.pgp>


More information about the xorg-devel mailing list