[PATCH 00/18] Xfbdev Atari and Amiga support

[Alan Coopersmith]

On 04/25/13 09:05 AM, Keith Packard wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
>
>> I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why
>> stuff isn't working, though FatalError() also works for something that
>> should be impossible to hit.
>
> How about this:
>
> commit e779402d531625ba4ed5d628d06c6b1e06b2ec7b
> Author: Keith Packard <keithp at keithp.com>
> Date:   Thu Apr 25 09:02:31 2013 -0700
>
>      shadow: Define c2p_unsupported
>
>      Just make this call BUG_WARN(1) to indicate that something unexpected
>      happened
>
>      Signed-off-by: Keith Packard <keithp at keithp.com>
>
> diff --git a/miext/shadow/c2p_core.h b/miext/shadow/c2p_core.h
> index 252f93e..a48e223 100644
> --- a/miext/shadow/c2p_core.h
> +++ b/miext/shadow/c2p_core.h
> @@ -41,7 +41,9 @@ static inline void _transp(CARD32 d[], unsigned int i1, unsign
>   }
>
>
> -extern void c2p_unsupported(void);
> +static inline void c2p_unsupported(void) {
> +    BUG_WARN(1);
> +}
>
>   static inline CARD32 get_mask(unsigned int n)
>   {
>
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc