[PATCH 00/18] Xfbdev Atari and Amiga support

[Keith Packard]

Alan Coopersmith <alan.coopersmith at oracle.com> writes:


> I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why
> stuff isn't working, though FatalError() also works for something that
> should be impossible to hit.

How about this:

commit e779402d531625ba4ed5d628d06c6b1e06b2ec7b
Author: Keith Packard <keithp at keithp.com>
Date:   Thu Apr 25 09:02:31 2013 -0700

    shadow: Define c2p_unsupported
    
    Just make this call BUG_WARN(1) to indicate that something unexpected
    happened
    
    Signed-off-by: Keith Packard <keithp at keithp.com>

diff --git a/miext/shadow/c2p_core.h b/miext/shadow/c2p_core.h
index 252f93e..a48e223 100644
--- a/miext/shadow/c2p_core.h
+++ b/miext/shadow/c2p_core.h
@@ -41,7 +41,9 @@ static inline void _transp(CARD32 d[], unsigned int i1, unsign
 }
 
 
-extern void c2p_unsupported(void);
+static inline void c2p_unsupported(void) {
+    BUG_WARN(1);
+}
 
 static inline CARD32 get_mask(unsigned int n)
 {


-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130425/f1fce7b7/attachment.pgp>