[PATCH] Xi: Don't check for TOUCH_END, it's never set

Peter Hutterer peter.hutterer at who-t.net
Thu Sep 27 19:50:34 PDT 2012

On Mon, Sep 10, 2012 at 11:49:33AM -0600, Daniel Drake wrote:
> On Fri, Sep 7, 2012 at 8:42 PM, Chase Douglas <chase.douglas at ubuntu.com> wrote:
> > I could have sworn this had been removed by now. I remember deleting
> > it at one point during one of my debugging sessions and being
> > surprised it was still there at that point.
> >
> > I agree that this should be removed. The question is: will this cause
> > any regression? I suggest running it through Peter's test repo, and I
> > would also suggest adding a test to it for the issue you have found,
> > too.
> Is that http://cgit.freedesktop.org/~whot/xorg-integration-tests/ ?
> (I don't see any touchscreen tests there)

sorry about the delay, I was away on holidays (and then XDC)
yes, that's the right repo, there are some XI2 tests in there already
(tests/server/xi2.cpp) and you can add to those.

> > Although I worry about it causing a regression elsewhere, there is
> > nothing in the patch that is wrong, so:
> >
> > Reviewed-by: Chase Douglas <chase.douglas at ubuntu.com>
> Does this mean its ok to be pushed to master? (I have access, just not
> sure about protocol)

xserver branches are only for the respective maintainers (keith for master).
I've picked your patch up and will send a pull request out soon. Please do
try to get a test for this though.

> Regarding regressions, I think touch support on xserver-1.13 needs a
> fresh look. To me, this suggests that nobody has tested basic
> touchscreen pointer emulation since April (presumably a986f2f30cb was
> the cause of this regression). And
> https://bugs.freedesktop.org/show_bug.cgi?id=54614 may suggest that
> the sequence of non-emulated touch events also has some fundamental
> problems.

yeah. we have no tests for this except the ones we did during development.
so no surprise this is falling apart. again, any tests you can provide will
be very helpful for regression detection.


More information about the xorg-devel mailing list