[PATCH] Xi: Don't check for TOUCH_END, it's never set

Daniel Drake dsd at laptop.org
Mon Sep 10 10:49:33 PDT 2012

On Fri, Sep 7, 2012 at 8:42 PM, Chase Douglas <chase.douglas at ubuntu.com> wrote:
> I could have sworn this had been removed by now. I remember deleting
> it at one point during one of my debugging sessions and being
> surprised it was still there at that point.
> I agree that this should be removed. The question is: will this cause
> any regression? I suggest running it through Peter's test repo, and I
> would also suggest adding a test to it for the issue you have found,
> too.

Is that http://cgit.freedesktop.org/~whot/xorg-integration-tests/ ?

(I don't see any touchscreen tests there)

> Although I worry about it causing a regression elsewhere, there is
> nothing in the patch that is wrong, so:
> Reviewed-by: Chase Douglas <chase.douglas at ubuntu.com>

Does this mean its ok to be pushed to master? (I have access, just not
sure about protocol)

Regarding regressions, I think touch support on xserver-1.13 needs a
fresh look. To me, this suggests that nobody has tested basic
touchscreen pointer emulation since April (presumably a986f2f30cb was
the cause of this regression). And
https://bugs.freedesktop.org/show_bug.cgi?id=54614 may suggest that
the sequence of non-emulated touch events also has some fundamental


More information about the xorg-devel mailing list