pull req (review req in disguise)

Keith Packard keithp at keithp.com
Mon Sep 3 22:43:43 PDT 2012


Dave Airlie <airlied at gmail.com> writes:

> Hi Keith,
>
> This is hotplug and udev stuff.
>
> You reviewed one of the hotplug ones, the other fixes providers on
> recycle, needs more work in the future but it good for now.
>
> The 3 udev patches have been tested to make sure that seat supports
> works with output hotplug devices and we are shipping them in Fedora,
> I meant to get whot to review at least the first couple, but he's on
> holidays now.
>
> Dave.
>
> The following changes since commit 6619f5c0e1086b57888ff7146e8ed5897b50d440:
>
>   Relase 1.12.99.905 (2012-08-21 13:46:34 -0700)
>
> are available in the git repository at:
>
>   ssh://people.freedesktop.org/~airlied/xserver for-keithp
>
> for you to fetch changes up to 055c02e66a5702259db2988828ad78c7954a596e:
>
>   xf86: fix multi-seat video device support. (2012-09-03 13:37:07 +1000)
>
> ----------------------------------------------------------------
> Dave Airlie (5):
>       xf86/crtc: don't free config->name

Reviewed-by: Keith Packard <keithp at keithp.com>

>       config/udev: add wrapper around check if server is not seat 0

Make this look like a function call please. Otherwise, it looks like
it's just referencing a global variable.

>       config/udev: respect seat for hotplugged video devices.

This seems like a reasonable parallel construct from the existing device
code.

Needs to be fixed for the above change, otherwise --

Reviewed-by: Keith Packard <keithp at keithp.com>

>       xf86: fix multi-seat video device support.

This looks like a fairly significant functional change to me; I'm really
uncomfortable merging it at this point in the 1.13 cycle.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120903/23feeaa9/attachment.pgp>


More information about the xorg-devel mailing list