[PATCH] configure.ac: Add resourceproto and scrnsaverproto to SDK_REQUIRED_MODULES

[Gaetan Nadon]

On 12-10-21 03:29 PM, Emil Velikov wrote:
> Note: This is a candidate for the master and 1.13 branches
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  configure.ac | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index e686614..c464a9d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1028,12 +1028,14 @@ AM_CONDITIONAL(SCREENSAVER, [test "x$SCREENSAVER" = xyes])
>  if test "x$SCREENSAVER" = xyes; then
>  	AC_DEFINE(SCREENSAVER, 1, [Support MIT-SCREEN-SAVER extension])
>  	REQUIRED_MODULES="$REQUIRED_MODULES $SCRNSAVERPROTO"
> +	SDK_REQUIRED_MODULES="$SDK_REQUIRED_MODULES $SCRNSAVERPROTO"
>  fi
>  
>  AM_CONDITIONAL(RES, [test "x$RES" = xyes])
>  if test "x$RES" = xyes; then
>  	AC_DEFINE(RES, 1, [Support X resource extension])
>  	REQUIRED_MODULES="$REQUIRED_MODULES $RESOURCEPROTO"
> +	SDK_REQUIRED_MODULES="$SDK_REQUIRED_MODULES $RESOURCEPROTO"
>  fi
>  
>  # The XRes extension may support client ID tracking only if it has

The commit text should explain *why* this is needed.

Note that SDK_REQUIRED_MODULES is used in xorg-server.pc.in:

    Requires.private: @SDK_REQUIRED_MODULES@

Any video/input driver will fail to build if the screen saver proto is
not present now while it was present at server build time.

As suggested by Dan Nicholson,

    Future additions to {SDK_,}REQUIRED_MODULES would require a review of
    whether the module is exposed in the API. Not much you can do here
    except be careful when introducing API.

http://lists.x.org/archives/xorg-devel/2010-June/010164.html



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121022/edeaee98/attachment.html>