<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 12-10-21 03:29 PM, Emil Velikov
wrote:<br>
</div>
<blockquote
cite="mid:1350847794-1800-1-git-send-email-emil.l.velikov@gmail.com"
type="cite">
<pre wrap="">Note: This is a candidate for the master and 1.13 branches
Signed-off-by: Emil Velikov <a class="moz-txt-link-rfc2396E" href="mailto:emil.l.velikov@gmail.com"><emil.l.velikov@gmail.com></a>
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
index e686614..c464a9d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1028,12 +1028,14 @@ AM_CONDITIONAL(SCREENSAVER, [test "x$SCREENSAVER" = xyes])
if test "x$SCREENSAVER" = xyes; then
AC_DEFINE(SCREENSAVER, 1, [Support MIT-SCREEN-SAVER extension])
REQUIRED_MODULES="$REQUIRED_MODULES $SCRNSAVERPROTO"
+ SDK_REQUIRED_MODULES="$SDK_REQUIRED_MODULES $SCRNSAVERPROTO"
fi
AM_CONDITIONAL(RES, [test "x$RES" = xyes])
if test "x$RES" = xyes; then
AC_DEFINE(RES, 1, [Support X resource extension])
REQUIRED_MODULES="$REQUIRED_MODULES $RESOURCEPROTO"
+ SDK_REQUIRED_MODULES="$SDK_REQUIRED_MODULES $RESOURCEPROTO"
fi
# The XRes extension may support client ID tracking only if it has
</pre>
</blockquote>
<br>
The commit text should explain *why* this is needed.<br>
<br>
Note that SDK_REQUIRED_MODULES is used in xorg-server.pc.in:<br>
<blockquote><tt>Requires.private: @SDK_REQUIRED_MODULES@</tt><tt><br>
</tt></blockquote>
Any video/input driver will fail to build if the screen saver proto
is not present now while it was present at server build time.<br>
<br>
As suggested by Dan Nicholson,<br>
<blockquote>
<pre>Future additions to {SDK_,}REQUIRED_MODULES would require a review of
whether the module is exposed in the API. Not much you can do here
except be careful when introducing API.</pre>
</blockquote>
<a class="moz-txt-link-freetext" href="http://lists.x.org/archives/xorg-devel/2010-June/010164.html">http://lists.x.org/archives/xorg-devel/2010-June/010164.html</a><br>
<br>
<br>
<br>
</body>
</html>