[PATCH 0/7] Resume breaking ABI
Colin Harrison
colin.harrison at virgin.net
Fri Oct 5 11:20:03 PDT 2012
Hi,
> Care to submit a patch which updates all of the changed bitfields to
> unsigned?
Ooops...I meant probably OK for all compilers...not all fields.
K&R ANSI quotes stuff like...
"The ANSI standard makes fields even more implementation-dependent then did
the first edition."
I'm cross-compiling using gcc via MinGW for Windows...other compiler users
mileage may vary as bit-fields are not that common.
My patch is still only one line...and the compiler output should be checked,
I suppose, from an objdump that uses ClientRec?
--- ./include/save_dixstruct.h 2012-10-05 01:24:03.981982326 +0100
+++ ./include/dixstruct.h 2012-10-05 08:04:21.244045996 +0100
@@ -95,7 +95,7 @@
int big_requests:1; /* supports large requests */
int clientGone:1;
int closeDownMode:2;
- int clientState:2;
+ unsigned int clientState:2;
char smart_priority;
short noClientException; /* this client died or needs to be killed
*/
int priority;
Thanks,
Colin Harrison
More information about the xorg-devel
mailing list