[PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

Christopher James Halse Rogers christopher.halse.rogers at canonical.com
Tue Jun 19 19:32:51 PDT 2012

On Tue, 2012-06-19 at 14:38 -0400, Kristian Høgsberg wrote:
> On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard <keithp at keithp.com> wrote:
> > Christopher James Halse Rogers <christopher.halse.rogers at canonical.com>
> > writes:
> >
> >> +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic);
> >
> > Bikeshed -- seems like the 'fd' parameter is not needed in this API?
> > I'll note that in the implementation of the wrapper, you pull it from
> > the screen private instead of using the provided parameter...
> Oh, that is a good point, I like that bikeshed color better.

Technically I pull it from the DRI2Srceen private, which the driver
won't have access to, but {intel,nouveau,ati} also store this fd in
their driver private, so it's not a problem for them.

I'll send a blue-painted patch. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120620/2b80e69b/attachment.pgp>

More information about the xorg-devel mailing list