[PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

Kristian Høgsberg krh at bitplanet.net
Tue Jun 19 11:38:39 PDT 2012


On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard <keithp at keithp.com> wrote:
> Christopher James Halse Rogers <christopher.halse.rogers at canonical.com>
> writes:
>
>> +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic);
>
> Bikeshed -- seems like the 'fd' parameter is not needed in this API?
> I'll note that in the implementation of the wrapper, you pull it from
> the screen private instead of using the provided parameter...

Oh, that is a good point, I like that bikeshed color better.

Kristian


More information about the xorg-devel mailing list