Re: 答复: [PATCH]new driver for siliconmotion

[Michal Suchanek]

On 17 July 2012 10:31, Aaron.Chen  陈俊杰 <aaron.chen at siliconmotion.com> wrote:
> Hi Matt,
>
> We really appreciate your advice! The project is very important to us! We have worked for the project for two years. It can support all the SMI graphics chips and works OK on FC, SUSE, Ubuntu Red Hat, etc. for both 32 and 64 bit OS. The code contains two different types of driver. One is support XRandr and the other is not which is for multi-adapter.
> So it may remain some old structure files.
>
> And one more question asked by our develop team:
>>" Do we really have to prefix all these files and directories with 'ddk'?"
>
> So, We'd better change all the name of files named "ddk*". Is that right?
> Aaron

I guess this is not really a requirement but makes the code needlessly
unattractive.

Since this is an initial submission it is the right time to change this.

If you look at the other drivers they have rather simple structure
with all files in a single directory. Large part of the code is
shared. When support for new chipset family is added a few files
specific to that chipset are typically required which have the chipset
name in their file name but much of the rest is just updated slightly.

Now you add support for half dozen of chips and I have no idea how
they are related to each other and to the chips previously supported
by the smi driver. You should know the best since you wrote the code.

However, the file naming suggests that you started with separate
driver for every chip and just added hooks in the old driver to call
one or the other with very little sharing.

This has both advantages and drawbacks but with few people working on
the code the less needs to be maintained the better. Then sharing as
much code as reasonably possible makes sense, and making bazillion
subdirectories does not help that.

Thanks

Michal