答复: [PATCH]new driver for siliconmotion

[Aaron.Chen 陈俊杰]

Hi Matt,

We really appreciate your advice! The project is very important to us! We have worked for the project for two years. It can support all the SMI graphics chips and works OK on FC, SUSE, Ubuntu Red Hat, etc. for both 32 and 64 bit OS. The code contains two different types of driver. One is support XRandr and the other is not which is for multi-adapter.
So it may remain some old structure files. 

And one more question asked by our develop team: 
>" Do we really have to prefix all these files and directories with 'ddk'?" 

So, We'd better change all the name of files named "ddk*". Is that right?
Aaron


-----邮件原件-----
发件人: Aaron.Chen 陈俊杰
发送时间: 2012年7月12日 10:17
收件人: 'Matt Turner'
抄送: xorg-devel at lists.x.org; caesar.qiu 裘赛海
主题: 答复: [PATCH]new driver for siliconmotion

Hi Matt,

Thank you for your review. We really appreciate that you've pick out so many issues we need to improve. It seems that we still have a lot of work to do to match the quality which can be accepted by X.Org. We will fix the issue you've reported before next submission.
One more question: How many patches shall I make instead of one big patch?

Aaron

-----邮件原件-----
发件人: Matt Turner [mailto:mattst88 at gmail.com]
发送时间: 2012年7月12日 0:32
收件人: Aaron.Chen 陈俊杰
抄送: xorg-devel at lists.x.org; caesar.qiu 裘赛海
主题: Re: [PATCH]new driver for siliconmotion

On Tue, Jul 10, 2012 at 8:24 PM, Matt Turner <mattst88 at gmail.com> wrote:
> 64 Megabytes in bytes is too large for a signed int. This code cannot 
> work. It's clear that someone thought about this, since there's a 
> more-correct commented-out function signature above it.

Math fail. Ignore this hunk. The commented-out signature should be removed though.