[PATCH] Do not unconditionally define DEBUG.

Thomas Klausner wiz at NetBSD.org
Thu Jul 12 08:22:10 PDT 2012

On Wed, Jul 11, 2012 at 05:56:45PM -0700, Alan Coopersmith wrote:
> Works for me.   Applied & pushed to git master:
> To ssh://git.freedesktop.org/git/xorg/app/xedit
>    33dacad..ce36f7b  master -> master

Thank you!

> As Matt noted, please include the module name in the [PATCH module] header
> for modules other than the xserver so it's easier to work out which they
> apply to (though in this case you'd said in the previous e-mail so it wasn't
> a mystery unlike some of the ones we get).

Will do.

> You can have git set this for
> you via git config - for instance, in my xedit repo, "git config -l" shows
> I've set:
> 	format.subjectprefix=PATCH:xedit
> (When I cloned all the repos I wrote a quick shell foreach loop that I sadly
>  didn't save, but was something like:
>    foreach d (*)
>      env GIT_DIR=$d git config format.subjectprefix="PATCH:$d:t"
>    end
>  in tcsh syntax.)

I tried this for adobe-100dpi using zsh and git-
"for d in adobe-100dpi; do GIT_DIR=$d git config format.subjectprefix="PATCH:$d:t"; done"
but got:
error: invalid key: format.subjectprefix=PATCH:adobe-100dpi

> For longer patches, we prefer to have Signed-off-by: lines indicating you have
> a reasonable belief you have the rights to contribute the code under the modules
> license.

Ok, I'll sign-off the commits in the future.

Let me know of anything else I can do to make including the changes as
easy as possible.


More information about the xorg-devel mailing list