[PATCH] Do not unconditionally define DEBUG.
Alan Coopersmith
alan.coopersmith at oracle.com
Wed Jul 11 17:56:45 PDT 2012
On 07/11/12 04:30 AM, Thomas Klausner wrote:
> ---
> lisp/re/re.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/re/re.c b/lisp/re/re.c
> index fca7e28..f4c1246 100644
> --- a/lisp/re/re.c
> +++ b/lisp/re/re.c
> @@ -31,7 +31,7 @@
>
> #include <stdio.h>
> #include "rep.h"
> -#define DEBUG
> +
> /*
> * Types
> */
Works for me. Applied & pushed to git master:
To ssh://git.freedesktop.org/git/xorg/app/xedit
33dacad..ce36f7b master -> master
As Matt noted, please include the module name in the [PATCH module] header
for modules other than the xserver so it's easier to work out which they
apply to (though in this case you'd said in the previous e-mail so it wasn't
a mystery unlike some of the ones we get). You can have git set this for
you via git config - for instance, in my xedit repo, "git config -l" shows
I've set:
format.subjectprefix=PATCH:xedit
(When I cloned all the repos I wrote a quick shell foreach loop that I sadly
didn't save, but was something like:
foreach d (*)
env GIT_DIR=$d git config format.subjectprefix="PATCH:$d:t"
end
in tcsh syntax.)
For longer patches, we prefer to have Signed-off-by: lines indicating you have
a reasonable belief you have the rights to contribute the code under the modules
license.
More details/docs are available in:
http://www.x.org/wiki/Development/Documentation/SubmittingPatches
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
More information about the xorg-devel
mailing list