[PATCH libxkbcommon] Use yacc-generated header instead of tokens.h

Gaetan Nadon memsize at videotron.ca
Sun Feb 26 08:42:58 PST 2012


On 12-02-25 12:38 PM, Ran Benita wrote:
> The yacc implementation can generate all the necessary token
> definitions itself; there is no need to maintain a hand written
> file for that.
>
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
> Resending this one as suggested by Gaetan Nadon. Should apply cleanly
> after the other fix patches. Tested to work both with bison and byacc.
>
>  src/xkbcomp/.gitignore  |    1 +
>  src/xkbcomp/Makefile.am |    4 +-
>  src/xkbcomp/tokens.h    |  105 -----------------------------------------------
>  src/xkbcomp/xkbscan.l   |    2 +-
>  4 files changed, 5 insertions(+), 107 deletions(-)
>  delete mode 100644 src/xkbcomp/tokens.h
Reviewed-by: Gaetan Nadon<memsize at videotron.ca>

Thanks, this is a good improvement.


More information about the xorg-devel mailing list