[PATCH 1/2] Add some intramodule dependencies

Mark Kettenis mark.kettenis at xs4all.nl
Tue Sep 20 00:44:27 PDT 2011


> Date: Mon, 19 Sep 2011 15:24:19 -0700
> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
> On 09/19/11 15:12, Aaron Plattner wrote:
> > On Mon, Sep 19, 2011 at 02:51:07PM -0700, Alan Coopersmith wrote:
> >> libshadow depends on libfb for fbGetWinPrivateKey
> >> libvbe depends on libint10 for xf86Int10AllocPages, xf86Int10FreePages,
> >>   xf86ExecX86int10, xf86ExtendedInitInt10, xf86FreeInt10, xf86int10Addr
> >>
> >> Signed-off-by: Alan Coopersmith<alan.coopersmith at oracle.com>
> >> ---
> >>   hw/xfree86/dixmods/Makefile.am |    1 +
> >>   hw/xfree86/vbe/Makefile.am     |    1 +
> >>   2 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/xfree86/dixmods/Makefile.am b/hw/xfree86/dixmods/Makefile.am
> >> index 1a162ab..10001a5 100644
> >> --- a/hw/xfree86/dixmods/Makefile.am
> >> +++ b/hw/xfree86/dixmods/Makefile.am
> >> @@ -59,6 +59,7 @@ librecord_la_SOURCES = recordmod.c
> >>
> >>   libshadow_la_LDFLAGS = -avoid-version
> >>   libshadow_la_LIBADD = $(top_builddir)/miext/shadow/libshadow.la
> >> +libshadow_la_LIBADD += libfb.la
> >
> > Just linking these together doesn't seem right, since it won't initialize
> > it as a module.  Should it call xf86LoadSubModule at runtime instead?
> 
> Honestly, I don't know - this patch was added to our server as part
> of work to satisfy linker dependencies, and I'm not that familiar
> with xf86LoadSubModule.

Alan, isn't the the problem of the linker dependencies solved by
adding -module like you did in the diff for the driver modules you
sent out a couple of days ago?


More information about the xorg-devel mailing list