[PATCH 1/2] Add some intramodule dependencies

[Alan Coopersmith]

On 09/19/11 15:12, Aaron Plattner wrote:
> On Mon, Sep 19, 2011 at 02:51:07PM -0700, Alan Coopersmith wrote:
>> libshadow depends on libfb for fbGetWinPrivateKey
>> libvbe depends on libint10 for xf86Int10AllocPages, xf86Int10FreePages,
>>   xf86ExecX86int10, xf86ExtendedInitInt10, xf86FreeInt10, xf86int10Addr
>>
>> Signed-off-by: Alan Coopersmith<alan.coopersmith at oracle.com>
>> ---
>>   hw/xfree86/dixmods/Makefile.am |    1 +
>>   hw/xfree86/vbe/Makefile.am     |    1 +
>>   2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/xfree86/dixmods/Makefile.am b/hw/xfree86/dixmods/Makefile.am
>> index 1a162ab..10001a5 100644
>> --- a/hw/xfree86/dixmods/Makefile.am
>> +++ b/hw/xfree86/dixmods/Makefile.am
>> @@ -59,6 +59,7 @@ librecord_la_SOURCES = recordmod.c
>>
>>   libshadow_la_LDFLAGS = -avoid-version
>>   libshadow_la_LIBADD = $(top_builddir)/miext/shadow/libshadow.la
>> +libshadow_la_LIBADD += libfb.la
>
> Just linking these together doesn't seem right, since it won't initialize
> it as a module.  Should it call xf86LoadSubModule at runtime instead?

Honestly, I don't know - this patch was added to our server as part of work
to satisfy linker dependencies, and I'm not that familiar with xf86LoadSubModule.

Is there any time libfb wouldn't be already initialized?   Now that cfb etal
are dead, does it make sense to still have fb as a loadable module instead
of just building it into the core server?

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System