[PATCH libXi multitouch 3/4] Define macros for unstable protocol development

Chase Douglas chase.douglas at canonical.com
Sat Sep 17 09:54:25 PDT 2011


On 09/17/2011 06:53 AM, Gaetan Nadon wrote:
> On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote:
>> On Wed, Sep 14, 2011 at 10:33:56PM -0700, Chase Douglas wrote:
>> > Signed-off-by: Chase Douglas <chase.douglas at canonical.com <mailto:chase.douglas at canonical.com>>
>> > ---
>> >  configure.ac |    3 +++
>> >  1 files changed, 3 insertions(+), 0 deletions(-)
>> > 
>> > diff --git a/configure.ac b/configure.ac
>> > index 6c2f731..f3d6d8e 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -39,6 +39,9 @@ if ! test "x$UNSTABLE_LIB" = xyes; then
>> >      AC_MSG_ERROR([This branch contains elements which have not yet been finalised.  When this branch is updated, you will probably need to recompile both the any clients using the library, and may experience crashes or undefined behaviour if you do not.])
>> >  fi
>> >  
>> > +# Define macros for compiling with unstable protocols
>> > +AC_SUBST(CFLAGS, "-DXINPUT2_1_USE_UNSTABLE_PROTOCOL -DXINPUT2_2_USE_UNSTABLE_PROTOCOL")
> CFLAGS is a user environment and should never be set in configure.ac. In
> some case it is, for a configure test, but restored to the original
> value. Refer to Automake documentation for a complete discussion on env
> variable usage.

A couple points:

* This is only temporary while the protocol is under development. It
will not be part of any official libXi release.

* When I have used AC_SUBST before, it has only appended flags to the
CFLAGS env var. This is exactly what we want.

* I can't find any documentation providing guidelines, so if you have
any please share :).

Thanks!

-- Chas


More information about the xorg-devel mailing list