[PATCH libXi multitouch 3/4] Define macros for unstable protocol development

Gaetan Nadon memsize at videotron.ca
Sat Sep 17 06:53:01 PDT 2011


On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote:

> On Wed, Sep 14, 2011 at 10:33:56PM -0700, Chase Douglas wrote:
> > Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> > ---
> >  configure.ac |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 6c2f731..f3d6d8e 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -39,6 +39,9 @@ if ! test "x$UNSTABLE_LIB" = xyes; then
> >      AC_MSG_ERROR([This branch contains elements which have not yet been finalised.  When this branch is updated, you will probably need to recompile both the any clients using the library, and may experience crashes or undefined behaviour if you do not.])
> >  fi
> >  
> > +# Define macros for compiling with unstable protocols
> > +AC_SUBST(CFLAGS, "-DXINPUT2_1_USE_UNSTABLE_PROTOCOL -DXINPUT2_2_USE_UNSTABLE_PROTOCOL")

CFLAGS is a user environment and should never be set in configure.ac. In
some case it is, for a configure test, but restored to the original
value. Refer to Automake documentation for a complete discussion on env
variable usage.

> > +
> 
> I think the 2.1 protocol is stable enough so we don't need the first define.
> it's not in master anyway.
> 
> Cheers,
>   Peter
> 
> >  # Check for xmlto and asciidoc for man page conversion
> >  # (only needed by people building tarballs)
> >  if test "$have_xmlto" = yes && test "$have_asciidoc" = yes; then
> > -- 
> > 1.7.4.1
> > 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110917/8271ab03/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110917/8271ab03/attachment.pgp>


More information about the xorg-devel mailing list