[PATCH] configure.ac: Remove unreachable check for VM86 headers.
alan.coopersmith at oracle.com
Thu Sep 15 19:37:01 PDT 2011
On 09/14/11 09:11, Jamey Sharp wrote:
> On Wed, Sep 14, 2011 at 10:39:53AM -0500, Alan Coopersmith wrote:
>> On 09/14/11 10:07 AM, Jamey Sharp wrote:
>>> "configure --with-int10=yes" is not a valid configuration, and the check
>>> for sys/vm86.h and sys/io.h is not used. Delete it.
>>> AM_CONDITIONAL(INT10_VM86, [test "x$INT10" = xvm86])
>>> AM_CONDITIONAL(INT10_X86EMU, [test "x$INT10" = xx86emu])
>>> AM_CONDITIONAL(INT10_STUB, [test "x$INT10" = xstub])
>>> -if test "x$INT10" = xyes; then
>>> - dnl VM86 headers
>>> - AC_CHECK_HEADERS([sys/vm86.h sys/io.h])
>> Should that be checking for "x$INT10" = xvm86 since it's checking
>> for the vm86 headers? Perhaps AC_ERRORing if vm86 is requested and
>> they're not
> Oddly, nothing in-tree #includes sys/vm86.h, not even the INT10_VM86
> implementation. So no, I think this block should just die.
> Some things do #include sys/io.h, but they aren't related to int10 and
> didn't use HAVE_SYS_IO_H.
Okay then, since this makes --with-int10=yes no more broken than it was before,
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Though if it really does produce a broken system, another patch to AC_MSG_ERROR
out when --with-int10= is passed something other than one of the valid values
would be good too.
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel