[PATCH] configure.ac: Remove unreachable check for VM86 headers.

Jamey Sharp jamey at minilop.net
Wed Sep 14 09:11:07 PDT 2011


On Wed, Sep 14, 2011 at 10:39:53AM -0500, Alan Coopersmith wrote:
> On 09/14/11 10:07 AM, Jamey Sharp wrote:
> >"configure --with-int10=yes" is not a valid configuration, and the check
> >for sys/vm86.h and sys/io.h is not used. Delete it.
> >  AM_CONDITIONAL(INT10_VM86, [test "x$INT10" = xvm86])
> >  AM_CONDITIONAL(INT10_X86EMU, [test "x$INT10" = xx86emu])
> >  AM_CONDITIONAL(INT10_STUB, [test "x$INT10" = xstub])
> >-if test "x$INT10" = xyes; then
> >-	dnl VM86 headers
> >-	AC_CHECK_HEADERS([sys/vm86.h sys/io.h])
> >-fi
> 
> Should that be checking for "x$INT10" = xvm86 since it's checking
> for the vm86 headers?   Perhaps AC_ERRORing if vm86 is requested and
> they're not
> found?

Oddly, nothing in-tree #includes sys/vm86.h, not even the INT10_VM86
implementation. So no, I think this block should just die.

Some things do #include sys/io.h, but they aren't related to int10 and
didn't use HAVE_SYS_IO_H.

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110914/76f6a07f/attachment.pgp>


More information about the xorg-devel mailing list