[PATCH] pci: Restore pciTag as a deprecated function

Jeremy Huddleston jeremyhu at apple.com
Thu Oct 20 00:11:39 PDT 2011


On Oct 19, 2011, at 23:45, Jamey Sharp wrote:

>> I think we coddled the drivers enough with the current set of
>> just-deprecations.  This is too trivial.  I'll just go through and
>> make sure nobody is actually using it because drivers still build
>> "successfully" due to us not using
>> -Werror=implicit-function-declaration
>> 
>> Perhaps we should add -Werror=implicit-function-declaration to all the
>> drivers...
> 
> Any reason not to add it to xorg-macros, and get the equivalents for Sun
> Studio and clang in too? I think it should be safe to say that every
> instance of an implicit function declaration anywhere in X.Org is a bug.

Maybe I'll roll it into the new warnings macro for util-macros (which also strips off -fno-strict-aliasing) ... $CWARNFLAGS_NO_REALLY_THIS_IS_JUST_WARNINGS_THIS_TIME or whatever.


More information about the xorg-devel mailing list