[PATCH] pci: Restore pciTag as a deprecated function

[Jamey Sharp]

On Wed, Oct 19, 2011 at 10:47:17AM -0700, Jeremy Huddleston wrote:
> Actually, I retract this.  I didn't intend to do it originally, but
> now that it's done, meh.

If you change your mind:

Reviewed-by: Jamey Sharp <jamey at minilop.net>

But I, for one, am perfectly happy with "meh". :-)

> I think we coddled the drivers enough with the current set of
> just-deprecations.  This is too trivial.  I'll just go through and
> make sure nobody is actually using it because drivers still build
> "successfully" due to us not using
> -Werror=implicit-function-declaration
> 
> Perhaps we should add -Werror=implicit-function-declaration to all the
> drivers...

Any reason not to add it to xorg-macros, and get the equivalents for Sun
Studio and clang in too? I think it should be safe to say that every
instance of an implicit function declaration anywhere in X.Org is a bug.

Jamey

> On Oct 19, 2011, at 12:20 AM, Jeremy Huddleston wrote:
> 
> > 
> > This partially reverts b3d56d06ef840bbbe16ec3c37e170078b7f98b04 to allow
> > driver developers time to adjust.
> > 
> > Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> > ---
> > The commit that deprecated the PCITAG type had these leftovers that I didn't mean to get rid of just yet.
> > 
> > hw/xfree86/os-support/bus/Pci.c     |    6 ++++++
> > hw/xfree86/os-support/bus/xf86Pci.h |    1 +
> > 2 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/hw/xfree86/os-support/bus/Pci.c b/hw/xfree86/os-support/bus/Pci.c
> > index 0362a00..f1dbfc2 100644
> > --- a/hw/xfree86/os-support/bus/Pci.c
> > +++ b/hw/xfree86/os-support/bus/Pci.c
> > @@ -126,6 +126,12 @@
> > 
> > #include "Pci.h"
> > 
> > +PCITAG
> > +pciTag(int busnum, int devnum, int funcnum)
> > +{
> > +	return(PCI_MAKE_TAG(busnum,devnum,funcnum));
> > +}
> > +
> > Bool
> > xf86scanpci(void)
> > {
> > diff --git a/hw/xfree86/os-support/bus/xf86Pci.h b/hw/xfree86/os-support/bus/xf86Pci.h
> > index 74ead20..55e631c 100644
> > --- a/hw/xfree86/os-support/bus/xf86Pci.h
> > +++ b/hw/xfree86/os-support/bus/xf86Pci.h
> > @@ -251,6 +251,7 @@ typedef enum {
> > 
> > 
> > /* Public PCI access functions */
> > +extern _X_EXPORT _X_DEPRECATED PCITAG pciTag(int busnum, int devnum, int funcnum);
> > extern _X_EXPORT Bool xf86scanpci(void);
> > 
> > /* Domain access functions.  Some of these probably shouldn't be public */
> > -- 
> > 1.7.7
> > 
> > 
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: http://lists.x.org/mailman/listinfo/xorg-devel
> > 
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111020/2b30fc37/attachment.pgp>