[PATCH xserver] config/udev: add input subsystem filter for udev events

[Dan Nicholson]

On Sun, May 22, 2011 at 9:00 AM, Daniel Kurtz <djkurtz at google.com> wrote:
> Thanks for the pointers.
> On Fri, May 20, 2011 at 11:55 AM, Peter Hutterer <peter.hutterer at who-t.net>
> wrote:
>>
>> On Thu, May 19, 2011 at 09:58:59PM +0200, Julien Cristau wrote:
>> > On Thu, May 19, 2011 at 16:22:22 +0800, Daniel Kurtz wrote:
>> >
>> > > libudev allows adding an efficient in-kernel filter on udev events.
>> > > Since we manually filter for ID_INPUT anyway, it seems reasonable to
>> > > ask the kernel to send only events for the input subsystem.
>> > >
>> > > This filtering is performed both for initial device enumeration, and
>> > > for subsequent udev events.
>> > >
>> > > Signed-off-by: Daniel Kurtz <djkurtz at google.com>
>> > > ---
>> > >  config/udev.c |    3 +++
>> > >  1 files changed, 3 insertions(+), 0 deletions(-)
>> > >
>> > Pretty sure we had that initially and it was removed.
>>
>> We did. thread here
>> http://lists.x.org/archives/xorg-devel/2010-January/004596.html
>>
>>    commit 84905007702da2c05a4f7446b3fc5ff52be49655
>>    Author: Thomas Jaeger
>>    Date:   Mon Jan 4 15:00:49 2010 -0500
>>
>>    udev: Don't filter subsystem "input"
>>
>>    This allows serial wacom devices to work, whose subsystem is "tty".
>
> The following looks like it was submitted by Thomas, and adds tty filter as
> was recommended in that thread:
> http://lists.x.org/archives/xorg-devel/2010-February/005614.html
> But, AFAICT, it was lost.  I don't see any review comments, nor do I see it
> in the tree.
> Does anybody remember why this was not accepted?

Right, that was before he sent the "don't filter on input" patch. It
was decided that instead of trying to filter on subsystems, we'd just
let the filtering happen on ID_INPUT* being set in udev rules. No one
was really sure what all the input device providing subsystems were.
Are you seeing issues with this?

--
Dan