[PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

[Michel Dänzer]

On Mon, 2011-03-28 at 08:47 -0700, Keith Packard wrote: 
> On Mon, 28 Mar 2011 10:04:23 +0200, Michel Dänzer <michel at daenzer.net> wrote:
> 
> > So once again, a fix is delayed because it's not considered quite
> > perfect yet.
> 
> Kristian is the maintainer of the DRI2 code, and so should be involved
> in reviewing changes there. I'm mostly just poking him to see if he has
> an opinion about this change.
> 
> Personally I would rather see the slightly more complicated fix done now
> so that it can be tested during the merge period. I agree that it's
> unlikely to ever show up on a profile as a hot-spot; it'll just be a
> constant small cost forever and never get fixed for fear of breaking it.

That's not the issue for me, rather the time to discuss, implement and
test the optimization.

Also, if Ville's idea of hanging everything off the window pixmap were
implemented, it would be moot.


> If delaying the patch into master gets more people to think about it,
> that seems like a good thing to me.

I'm sure the people affected by the problem will appreciate it...


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer