[PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

Keith Packard keithp at keithp.com
Mon Mar 28 08:47:23 PDT 2011


On Mon, 28 Mar 2011 10:04:23 +0200, Michel Dänzer <michel at daenzer.net> wrote:

> See the discussion with Ville about this.

Thanks for pointing that out; I had skipped that discussion once the
source of the bug was identified.

> So once again, a fix is delayed because it's not considered quite
> perfect yet.

Kristian is the maintainer of the DRI2 code, and so should be involved
in reviewing changes there. I'm mostly just poking him to see if he has
an opinion about this change.

Personally I would rather see the slightly more complicated fix done now
so that it can be tested during the merge period. I agree that it's
unlikely to ever show up on a profile as a hot-spot; it'll just be a
constant small cost forever and never get fixed for fear of breaking it.

If delaying the patch into master gets more people to think about it,
that seems like a good thing to me.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110328/190933b5/attachment.pgp>


More information about the xorg-devel mailing list