[PATCH xserver] GLX: Support TLS with better portability

Dan Nicholson dbn.lists at gmail.com
Wed Mar 23 05:43:03 PDT 2011

On Tue, Mar 22, 2011 at 9:13 PM, tom fogal <tfogal at sci.utah.edu> wrote:
> Jeremy Huddleston <jeremyhu at apple.com> writes:
>> AX_TLS detects when toolchains support __thread or
>> __declspec(thread), but existing code assumed __thread.
> Good find.
>>  configure.ac            |    1 +
> [snip]
>> +     AC_DEFINE(__XSERVER_TLS, ${ac_cv_tls}, [Thread local storage directive]
> The AX_TLS macro should AC_DEFINE_UNQUOTED "TLS".  I recommend using
> that instead of inventing our own define.

Yeah, that seems reasonable. Tom, is that what's done in mesa?

> I haven't looked to see if we have __thread anywhere else that should
> go away in favor of the macro, but I assume you have.
> Other than those little nitpicks:
>  Reviewed-by: Tom Fogal <tfogal at alumni.unh.edu>

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

More information about the xorg-devel mailing list