[PATCH xserver] GLX: Support TLS with better portability
tom fogal
tfogal at sci.utah.edu
Tue Mar 22 21:13:41 PDT 2011
Jeremy Huddleston <jeremyhu at apple.com> writes:
> AX_TLS detects when toolchains support __thread or
> __declspec(thread), but existing code assumed __thread.
Good find.
> configure.ac | 1 +
[snip]
> + AC_DEFINE(__XSERVER_TLS, ${ac_cv_tls}, [Thread local storage directive]
The AX_TLS macro should AC_DEFINE_UNQUOTED "TLS". I recommend using
that instead of inventing our own define.
I haven't looked to see if we have __thread anywhere else that should
go away in favor of the macro, but I assume you have.
Other than those little nitpicks:
Reviewed-by: Tom Fogal <tfogal at alumni.unh.edu>
Thanks,
-tom
More information about the xorg-devel
mailing list