[PATCH:libXt 1/2 v3] Add test framework similar to xserver and use it to test XtAsprintf

Alan Coopersmith alan.coopersmith at oracle.com
Mon Mar 14 21:47:05 PDT 2011

On 03/14/11 08:53 PM, Gaetan Nadon wrote:
> On Mon, 2011-03-14 at 19:27 -0700, Alan Coopersmith wrote:
>> v3: Use test macros from xorg-macros 1.1.3
>>     Improved GNU libc detection for malloc debug environment variables
>>     Fix MALLOC_PERTURB_ value to not be 0 or ~0 & comment about why.
> Need a .gitignore in the test directory

Will do.

> Shouldn't Makefile.am wrap the target around if HAVE_GLIB?

I didn't think that was necessary since the macros reported error if you had
unit tests enabled and glib was missing - did I miss something?

> The strange thing is that the test cases runs even if I configure --without-glib
> and GLIB flags are blank.

They won't build for me when I configure --without-glib:

  CC     Alloc.o
"Alloc.c", line 25: cannot find include file: <glib.h>
"Alloc.c", line 72: undefined symbol: gint32
"Alloc.c", line 72: syntax error before or at: r
"Alloc.c", line 75: undefined symbol: r
"Alloc.c", line 78: warning: implicit function declaration: g_assert
"Alloc.c", line 90: undefined symbol: gint
"Alloc.c", line 90: syntax error before or at: r1
"Alloc.c", line 93: undefined symbol: r2
"Alloc.c", line 93: undefined symbol: r1
"Alloc.c", line 105: warning: implicit function declaration: g_test_init
"Alloc.c", line 106: warning: implicit function declaration: g_test_bug_base
"Alloc.c", line 108: warning: implicit function declaration: g_test_add_func
"Alloc.c", line 111: warning: implicit function declaration: g_test_run
cc: acomp failed for Alloc.c

gmake[2]: *** [Alloc.o] Error 1

Which I guess does mean we need a if HAVE_GLIB too.

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list