[PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

Alan Coopersmith alan.coopersmith at oracle.com
Tue Mar 8 15:42:36 PST 2011


On 03/ 8/11 03:23 PM, Gaetan Nadon wrote:
>> +    int snlen, aslen;
> 
> Whitespace error

Will fix.

> Would it be the time to provide some common support for unit testing?
> We will soon end-up in a situation where every package does it differently,
> making it difficult to add test cases in multiple packages, having to learn
> each package option, variables and behaviors.
> 
> At a minimum, we should have a macro for the configure option so at least
> there is a common user interface.
> 
> Tests are only executed when running "make check", is the
> --enable-unit-tests really needed?
> 
> 
> A quick summary of how things look today:
> 
>     libXau: always enabled; no config option; no "test" dir
>     libXt and xserver: --enable-unit-tests; UNITTESTS; auto detected based on required support; has "test" dir
>     libxkbcommon: always enabled; no config option; has "test" dir
>     libxcb: autodetected based on "check"; HAVE_CHECK; has "tests" (plural) dir
> 
>     Outside xorg, but using all the lastest xorg macros, wacom has copied the server code verbatim

Yeah, it would probably be good to provide common framework, especially if that
makes it easier for people to start adding tests to more modules.   Seems like
we've accepted the glib test harness code as our common test code base for
in-tree unit tests.


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list