[PATCH modular 7/8] build.sh: improve error msg by adding full make command

Gaetan Nadon memsize at videotron.ca
Wed Jan 5 06:39:34 PST 2011


On Wed, 2011-01-05 at 08:48 +1000, Peter Hutterer wrote:

> same goes here btw, it'd be much nicer to read if you could swap $1
> etc. over for meaningful names. just reading this context, I'd have no
> idea what the error would convey.
> 
> same goes for e.g. process() too. but this can be a follow-up patch
> 

I have a TODO to fix them all, now that I have a sample one reviewed.

Same for Dan's suggestion regarding removal of superfluous fallback
case.
    *)
         ;;

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110105/8a585974/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110105/8a585974/attachment.pgp>


More information about the xorg-devel mailing list